• Registered: 2012-08-13
  • Posts: 4

Topic: XML not found - http vs https

Hi,

just found out why Juicybox (WP Plugin with Pro addon) stubbornly displayed "XML not found" in two of my browsers: they were using https://, while the Juicybox javascript looks for the config XML in http://.

You may want to change this behaviour at some point, I think, as it practically means I can't use Juicybox for any sites that have members areas, or where the backend work in the CMS is done over https. Or is there a setting I've missed somewhere?

Thanks, Phil

  • Registered: 2012-04-24
  • Posts: 5,904

Re: XML not found - http vs https

WP-Juicebox defines the path to the configUrl as an absolute URL.
As such, it does not rely on the 'juicebox.js' file to build up an absolute URL from a relative one.
Also, the absolute URL used to define the path to the configUrl within WP-Juicebox does not hardcode the 'http://' part.
It is constructed from the following code using the WordPress method wp_upload_dir(). If your WordPress installation is hosted on a secure server, then I would expect the method to return a URL starting with 'https://'.

$upload_dir = wp_upload_dir();
$gallery_filename = $upload_dir['baseurl'] . '/juicebox/' . $gallery_id . '.xml';

However, this does not seem to be the case. (I do not have a secure server on which to test.)
Try inserting the following code on line 1083 of 'wp-juicebox.js'.

if (strpos($gallery_filename, 'http') === 0 && is_ssl()) {
    $gallery_filename = str_replace('http://', 'https://', $gallery_filename);
}

Hopefully, this will resolve the issue and the fix can be included in the next version of WP-Juicebox.
Thank you for reporting.

  • Registered: 2012-08-13
  • Posts: 4

Re: XML not found - http vs https

Hi Steven,
I added your code into wp-juicebox.php (not .js), and it does what it should: write https into the javascript snippet when called from a secured page.
Thanks for your help, Phil

  • Registered: 2012-04-24
  • Posts: 5,904

Re: XML not found - http vs https

Thank you for testing and reporting back.
I will ensure that this fix is included into the next version of WP-Juicebox.